lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents
Date


> -----Original Message-----
> From: Andy Shevchenko [mailto:andriy.shevchenko@linux.intel.com]
> Sent: Wednesday, November 22, 2017 1:19 PM
> To: Mehta, Sohil <sohil.mehta@intel.com>; Joerg Roedel <joro@8bytes.org>;
> Alex Williamson <alex.williamson@redhat.com>
> Cc: David Woodhouse <dwmw2@infradead.org>; Raj, Ashok
> <ashok.raj@intel.com>; iommu@lists.linux-foundation.org; linux-
> kernel@vger.kernel.org; Jacob Pan <jacob.jun.pan@linux.intel.com>; Kammela,
> Gayatri <gayatri.kammela@intel.com>; Shankar, Ravi V
> <ravi.v.shankar@intel.com>; Yu, Fenghua <fenghua.yu@intel.com>
> Subject: Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show
> register contents
>
> On Wed, 2017-11-22 at 11:25 -0800, Sohil Mehta wrote:
> > From: Gayatri Kammela <gayatri.kammela@intel.com>
>
>
> > +static int intel_iommu_regs_open(struct inode *inode, struct file
> > *file)
> > +{
> > + return single_open(file, intel_iommu_debugfs_regs_show,
> > + inode->i_private);
> > +}
> > +
> > +static const struct file_operations intel_iommu_regs_fops = {
> > + .open = intel_iommu_regs_open,
> > + .read = seq_read,
> > + .llseek = seq_lseek,
> > + .release = single_release,
> > +};
>
> Please, be consistent with file name and functions, i.e.
>
> intel_iommu_debugfs_regs_show -> intel_iommu_regset_show
>
> and so on.
>
Sure, will update in v3. Thanks!
> Moreover, see the patch I have just sent [1] and use same
> DEFINE_SHOW_ATTRIBUTE() macro here. In that case we would easily move it
> to seq_file.h for everyone to use in the future.
That makes sense! I see your patch is not merged yet, so really cannot reuse the same macro. I will have to redefine it.
>
> > + if (!debugfs_create_file("intel_iommu_regset", S_IRUGO,
> > + iommu_debug_root, NULL,
> > &intel_iommu_regs_fops
>
> [1]: https://marc.info/?l=linux-bluetooth&m=151138535801354&w=2
>
>
> --
> Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Intel Finland Oy
\
 
 \ /
  Last update: 2017-11-27 22:18    [W:0.058 / U:1.788 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site