lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectApplied "ASoC: cs35l34: Delete two error messages for a failed memory allocation in cs35l34_i2c_probe()" to the asoc tree
    Date
    The patch

    ASoC: cs35l34: Delete two error messages for a failed memory allocation in cs35l34_i2c_probe()

    has been applied to the asoc tree at

    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

    All being well this means that it will be integrated into the linux-next
    tree (usually sometime in the next 24 hours) and sent to Linus during
    the next merge window (or sooner if it is a bug fix), however if
    problems are discovered then the patch may be dropped or reverted.

    You may get further e-mails resulting from automated or manual testing
    and review of the tree, please engage with people reporting problems and
    send followup patches addressing any issues that are reported if needed.

    If any updates are required or you are submitting further changes they
    should be sent as incremental updates against current git, existing
    patches will not be replaced.

    Please add any relevant lists and maintainers to the CCs when replying
    to this mail.

    Thanks,
    Mark

    From 4dbd91549200574c71e10176d0ca37beca6703ec Mon Sep 17 00:00:00 2001
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 22 Nov 2017 21:13:29 +0100
    Subject: [PATCH] ASoC: cs35l34: Delete two error messages for a failed memory
    allocation in cs35l34_i2c_probe()

    Omit extra messages for a memory allocation failure in this function.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    ---
    sound/soc/codecs/cs35l34.c | 10 +++-------
    1 file changed, 3 insertions(+), 7 deletions(-)

    diff --git a/sound/soc/codecs/cs35l34.c b/sound/soc/codecs/cs35l34.c
    index 1e05026bedca..6cbdbbe53940 100644
    --- a/sound/soc/codecs/cs35l34.c
    +++ b/sound/soc/codecs/cs35l34.c
    @@ -1007,10 +1007,8 @@ static int cs35l34_i2c_probe(struct i2c_client *i2c_client,
    cs35l34 = devm_kzalloc(&i2c_client->dev,
    sizeof(struct cs35l34_private),
    GFP_KERNEL);
    - if (!cs35l34) {
    - dev_err(&i2c_client->dev, "could not allocate codec\n");
    + if (!cs35l34)
    return -ENOMEM;
    - }

    i2c_set_clientdata(i2c_client, cs35l34);
    cs35l34->regmap = devm_regmap_init_i2c(i2c_client, &cs35l34_regmap);
    @@ -1047,11 +1045,9 @@ static int cs35l34_i2c_probe(struct i2c_client *i2c_client,
    pdata = devm_kzalloc(&i2c_client->dev,
    sizeof(struct cs35l34_platform_data),
    GFP_KERNEL);
    - if (!pdata) {
    - dev_err(&i2c_client->dev,
    - "could not allocate pdata\n");
    + if (!pdata)
    return -ENOMEM;
    - }
    +
    if (i2c_client->dev.of_node) {
    ret = cs35l34_handle_of_data(i2c_client, pdata);
    if (ret != 0)
    --
    2.15.0
    \
     
     \ /
      Last update: 2017-11-27 19:53    [W:3.123 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site