lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm64: fix missing 'const' qualifiers
On Mon, Nov 27, 2017 at 09:15:50AM -0800, Nick Desaulniers wrote:
> Checked call sites, looks like no one tries to modify these pointers.
> I too prefer to make things as const as possible, though I recently
> had a coworker refer to the propagation of const in a code base as a
> "Gordian knot," which I thought was eloquent.
>
> checkpatch mentions that there's one line that's over 80 chars, and
> that there's M$ DOS style line endings (but that may just be my client
> gmail, or yours (exchange?)). If you fix up that long line, then:

I happily use mutt, but my company's mail server is MS Outlook, so I
have to send everything with msmtp. It usually works. In fact, this
is the first complain for 2 years.

My checkpatch:
yury:linux$ scripts/checkpatch.pl const.patch
total: 0 errors, 0 warnings, 32 lines checked

const.patch has no obvious style problems and is ready for submission.

I guess, because 1 line is exactly 80 chars length, and because MS format
adds another symbol as line delimiter, we end up with 81 chars in line,
which makes checkpatch worrying.

CC Joe Perches and Andy Whitcroft for it.

> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

Thanks

\
 
 \ /
  Last update: 2017-11-27 19:00    [W:0.060 / U:0.112 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site