lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue
Date
On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote:
> On 26/11/17 01:50, Alex Frappier Lachapelle wrote:
>> + const struct comedi_lrange *lrange;
>
> NAK. The following lines of source code allocate memory pointed to by 'lrange' and modify it, so 'const' is not appropriate here.

Ian,

Wonder if it's worth putting a comment about this in the code. This has come up a
couple times.

Regards,
Hartley
\
 
 \ /
  Last update: 2017-11-27 18:52    [W:0.048 / U:1.012 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site