lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line
From
Date
On Mon, 2017-11-27 at 10:35 -0700, Logan Gunthorpe wrote:
>
> On 27/11/17 10:28 AM, Joe Perches wrote:
> > It doesn't miss any mark. It simply informs.
> > Correctness when fixing are a different world of problems.
>
> So how come the double standard?

No double stardard. One correctly informs that a bare
printk is not acceptable.

> Having a missing new line warning
> simply informs here too.

No it has a high false positive rate and newbies
act on that by submitting bad patches.'

\
 
 \ /
  Last update: 2017-11-27 18:43    [W:0.064 / U:0.284 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site