lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line
From
Date
On Mon, 2017-11-27 at 10:33 -0700, Logan Gunthorpe wrote:
> > > This is a valid false positive that I also missed. However, it can
> > > actually be very easily ignored by checking if the format string ends in
> > > %pV. There were about 100 cases in my results that match this.
> >
> > No, it can't be done that way.
> >
> > $ git grep '%pV\\n"' | wc -l
> > 56
> > $ git grep '%pV"' | wc -l
> > 146
> >
> > AFAIK: all of the above are correct as-is.
>
> Yes, I'm saying they are correct too. So the script would very easily
> notice this and not produce a warning. The first grep you did already
> weren't false positives because they ended in \\n and wouldn't have
> produced a warning. A very simple change to my patch ignores the second
> group. So what's wrong here?

It can't be determined if the vaf.fmt contains a \n termination.

\
 
 \ /
  Last update: 2017-11-27 18:42    [W:0.051 / U:0.800 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site