lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line
From
Date
On Mon, 2017-11-27 at 10:20 -0700, Logan Gunthorpe wrote:
>
> On 27/11/17 01:28 AM, Joe Perches wrote:
> > checkpatch already reports printks without KERN_<level>
> >
> > # printk should use KERN_* levels
> > if ($line =~ /\bprintk\s*\(\s*(?!KERN_[A-Z]+\b)/) {
> > WARN("PRINTK_WITHOUT_KERN_LEVEL",
> > "printk() should include KERN_<LEVEL> facility level\n" . $herecurr);
> > }
> >
>
> Yes, but that kind of misses the mark in a similar way a new line
> warning misses the mark. Consider:

It doesn't miss any mark. It simply informs.
Correctness when fixing are a different world of problems.

\
 
 \ /
  Last update: 2017-11-27 18:28    [W:0.095 / U:6.364 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site