Messages in this thread |  | | Subject | Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line | From | Joe Perches <> | Date | Mon, 27 Nov 2017 09:28:06 -0800 |
| |
On Mon, 2017-11-27 at 10:20 -0700, Logan Gunthorpe wrote: > > On 27/11/17 01:28 AM, Joe Perches wrote: > > checkpatch already reports printks without KERN_<level> > > > > # printk should use KERN_* levels > > if ($line =~ /\bprintk\s*\(\s*(?!KERN_[A-Z]+\b)/) { > > WARN("PRINTK_WITHOUT_KERN_LEVEL", > > "printk() should include KERN_<LEVEL> facility level\n" . $herecurr); > > } > > > > Yes, but that kind of misses the mark in a similar way a new line > warning misses the mark. Consider:
It doesn't miss any mark. It simply informs. Correctness when fixing are a different world of problems.
|  |