lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ntb: remove unneeded DRIVER_LICENSE #defines
On Fri, Nov 17, 2017 at 9:53 AM, Philippe Ombredanne
<pombredanne@nexb.com> wrote:
> On Fri, Nov 17, 2017 at 3:20 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>> There is no need to #define the license of the driver, just put it in
>> the MODULE_LICENSE() line directly as a text string.
>>
>> This allows tools that check that the module license matches the source
>> code license to work properly, as there is no need to unwind the
>> unneeded dereference, especially when the string is defined just a few
>> lines above the usage of it.
>>
>> Cc: Jon Mason <jdmason@kudzu.us>
>> Cc: Dave Jiang <dave.jiang@intel.com>
>> Cc: Allen Hubbe <Allen.Hubbe@emc.com>
>> Cc: Gary R Hook <gary.hook@amd.com>
>> Cc: Serge Semin <fancer.lancer@gmail.com>
>> Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
>
> Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>

Applied to my ntb-next branch.

Thanks,
Jon

> --
> Cordially
> Philippe Ombredanne

\
 
 \ /
  Last update: 2017-11-27 17:16    [W:0.046 / U:0.468 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site