lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line


On 26/11/17 11:11 PM, Julia Lawall wrote:
> I don't have a different warning if the string ends in a space. I have a
> different warning when one possible control-flow path is fine and another
> control-flow path is not. The space thing relates to guessing whether
> some other printing API function needs a newline or not.

Understood. For checkpatch, there only is warnings (of various types)
and I was referring to the guessing you mentioned. So if we see that a
call has no new line and the following one isn't a KERN_CONT, then based
on whether there's a space or not we potentially could have one of two
warnings:

WARNING: Log messages should end in a new line (\n)

or

WARNING: Given that your log message ends in a space and not a new line,
did you maybe mean to put a KERN_CONT or pr_cont somewhere in there?? By
the way, though, KERN_CONT use is discouraged and will create its own
warning when you fix it.

Logan

\
 
 \ /
  Last update: 2017-11-27 07:28    [W:0.059 / U:4.772 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site