[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [bisected] system hang after boot
Hi Peter,

On Wed, Nov 22, 2017 at 09:22:17PM +0100, Peter Zijlstra wrote:
> On Wed, Nov 22, 2017 at 06:26:59PM +0000, Will Deacon wrote:
> > Now, I can't see what the break_lock is doing here other than causing
> > problems. Is there a good reason for it, or can you just try removing it
> > altogether? Patch below.
> The main use is spin_is_contended(), which in turn ends up used in
> __cond_resched_lock() through spin_needbreak().
> This allows better lock wait times for PREEMPT kernels on platforms
> where the lock implementation itself cannot provide 'contended' state.
> In that capacity the write-write race shouldn't be a problem though.

I'm not sure why it isn't a problem: given that the break_lock variable
can read as 1 for a lock that is no longer contended and 0 for a lock that
is currently contended, then the __cond_resched_lock is likely to see a
value of 0 (i.e. spin_needbreak always return false) more often than no
since it's checked by the lock holder.

> That said, I'd not be horribly sad to see this go, I've always found it
> to be quite the ugly hack and taking it out should provide some
> incentive for better lock implementations for the archs relying on this.

Right, and they can always implement arch_spin_is_contended if they have
a good way to do it.

I'll post this diff as a full patch, since it's clearly needed to get some
s390 systems booting against with 4.15.


 \ /
  Last update: 2017-11-27 12:50    [W:0.075 / U:0.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site