lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] VFS: use synchronize_rcu_expedited() in namespace_unlock()
From
Date
On 10/26/2017 02:27 PM, Paul E. McKenney wrote:
> But just for completeness, one way to make this work across the board
> might be to instead use call_rcu(), with the callback function kicking
> off a workqueue handler to do the rest of the unmount. Of course,
> in saying that, I am ignoring any mutexes that you might be holding
> across this whole thing, and also ignoring any problems that might arise
> when returning to userspace with some portion of the unmount operation
> still pending. (For example, someone unmounting a filesystem and then
> immediately remounting that same filesystem.)

You really need to complete all side effects of deallocating a resource
before returning to user space. Otherwise, it will never be possible to
allocate and deallocate resources in a tight loop because you either get
spurious failures because too many unaccounted deallocations are stuck
somewhere in the system (and the user can't tell that this is due to a
race), or you get an OOM because the user manages to queue up too much
state.

We already have this problem with RLIMIT_NPROC, where waitpid etc.
return before the process is completely gone. On some
kernels/configurations, the resulting race is so wide that parallel make
no longer works reliable because it runs into fork failures.

Thanks,
Florian

\
 
 \ /
  Last update: 2017-11-27 12:27    [W:0.100 / U:1.124 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site