lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line


On Sun, 26 Nov 2017, Logan Gunthorpe wrote:

>
>
> On 26/11/17 03:29 PM, Joe Perches wrote:
> > This proposal has a very high false positive rate.
>
> The only actual false positive you've pointed out is the one that is
> just incorrect in the wrong way (the author should have used a KERN_CONT
> but did not). I could easily do something similar to what Julia proposes
> and produce a different warning if the string ends in a space.

I don't have a different warning if the string ends in a space. I have a
different warning when one possible control-flow path is fine and another
control-flow path is not. The space thing relates to guessing whether
some other printing API function needs a newline or not.

julia

> But I
> don't see any bullet proof way for any script to deduce what the author
> actually meant.
>
> > Keep at it though.
> > Maybe something useful will be produced with more effort.
>
> Unless there's more actually constructive criticism I don't think I'll
> be getting any further with this.
>
> Logan
>

\
 
 \ /
  Last update: 2017-11-27 07:12    [W:0.098 / U:6.076 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site