lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line
From
Date
On Mon, 2017-11-27 at 10:32 +0100, Julia Lawall wrote:
> On Mon, 27 Nov 2017, Joe Perches wrote:
[]
> > below: the gig_dbg macro and _many_ other append a newline to a format
>
> Still, it seems that the file must contain a bug elsewhere, because the
> presence of this report means that some other call ended in a newline. It
> could be reasonable to highlight the least popular.
>
> thanks,
> julia
>
> > diff -u -p a/drivers/isdn/gigaset/ev-layer.c b/drivers/isdn/gigaset/ev-layer.c
> > --- a/drivers/isdn/gigaset/ev-layer.c
> > +++ b/drivers/isdn/gigaset/ev-layer.c
> > @@ -411,7 +411,7 @@ static void add_cid_event(struct cardsta
> > unsigned next, tail;
> > struct event_t *event;
> >
> > - gig_dbg(DEBUG_EVENT, "queueing event %d for cid %d", type, cid);
> > + gig_dbg(DEBUG_EVENT, "queueing event %d for cid %d\n", type, cid);
> >
> > spin_lock_irqsave(&cs->ev_lock, flags);
> >
> > etc...

Sure, but more than anything, this shows the difficulty
of automating these changes.

Variability of style is high and highlighting was might
be defective produces a lot of noise.

Perhaps the S/N ratio of your script is somewhat better
than the other proposal.

\
 
 \ /
  Last update: 2017-11-27 10:43    [W:0.085 / U:8.432 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site