lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] mmc: usdhi6rol0: Handle return value of platform_get_irq_byname for card detect
On 17 November 2017 at 17:35, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> platform_get_irq_byname() can fail here and we must check its return value.

NAK.

You need to check the code more carefully. irq_cd is dealt with later
below in the same function with proper error handling.

>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/mmc/host/usdhi6rol0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c
> index cdfeb15..5a896de 100644
> --- a/drivers/mmc/host/usdhi6rol0.c
> +++ b/drivers/mmc/host/usdhi6rol0.c
> @@ -1749,7 +1749,7 @@ static int usdhi6_probe(struct platform_device *pdev)
> irq_cd = platform_get_irq_byname(pdev, "card detect");
> irq_sd = platform_get_irq_byname(pdev, "data");
> irq_sdio = platform_get_irq_byname(pdev, "SDIO");
> - if (irq_sd < 0 || irq_sdio < 0)
> + if (irq_cd < 0 || irq_sd < 0 || irq_sdio < 0)
> return -ENODEV;
>
> mmc = mmc_alloc_host(sizeof(struct usdhi6_host), dev);
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2017-11-27 10:32    [W:0.030 / U:0.708 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site