lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line
From
Date
On Mon, 2017-11-27 at 09:52 +0100, Julia Lawall wrote:
> On Mon, 27 Nov 2017, Joe Perches wrote:
> > On Sun, 2017-11-26 at 23:40 -0700, Logan Gunthorpe wrote:
> > > On 26/11/17 11:34 PM, Julia Lawall wrote:
> > > > It would probably be better not to mention the KERN_CONT possibility at
> > > > all.
> > >
> > > Oh? I don't disagree... but what are we supposed to do in these cases?
> > > The way v2 of my patch works it just says that there is a missing new
> > > line. But Joe calls that a false positive. So if we can't report that
> > > it's missing a new line and we can't say it looks like it needs a
> > > KERN_CONT, then what can we do? The case is obviously wrong in some way
> > > or another so we probably shouldn't just ignore it.
>
> I meant why not only suggest pr_cont?

Because checkpatch cannot know if the printk is missing a
KERN_CONT or another different KERN_<LEVEL>.

\
 
 \ /
  Last update: 2017-11-27 10:07    [W:0.069 / U:3.388 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site