lkml.org 
[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] bcache: Use PTR_ERR_OR_ZERO()
From
Date
On 28/11/2017 7:05 AM, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/md/bcache/btree.c:1800:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>

Looks good to me. Reviewed-by: Coly Li <colyli@suse.de>

Thanks.

Coly Li

> ---
> drivers/md/bcache/btree.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 658c54b3b07a..f43e49979cb2 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -1797,10 +1797,7 @@ static int bch_gc_thread(void *arg)
> int bch_gc_thread_start(struct cache_set *c)
> {
> c->gc_thread = kthread_run(bch_gc_thread, c, "bcache_gc");
> - if (IS_ERR(c->gc_thread))
> - return PTR_ERR(c->gc_thread);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(c->gc_thread);
> }
>
> /* Initial partial gc */
>

\
 
 \ /
  Last update: 2017-11-28 04:40    [W:0.046 / U:5.392 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site