[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/5] add printk specifier %px, unique identifier
On Mon, Nov 27, 2017 at 4:03 PM, Linus Torvalds
<> wrote:
> So the big remaining ones for me are the /proc/<pid>/stack (stack
> pointers) and the /proc/net/* ones.
> I'm a bit disappointed that those haven't been fixed already and
> aren't even in this series..

Oh well, I just did /proc/<pid>/stack by making it just print 0
unconditionally rather than the hex number.

Looking around, not even proc-ps actually uses that file, and it's
conditional on PROC_STACKTRACE anyway. And can't recall ever having
seen a report of something breaking due to CONFIG_STACKTRACE not being
enabled, so I suspect nothing really uses /proc/<pid>/stack at all.

But rather than removing it, making it report 0 seemed the smaller change.

I'd be inclined to do the same for /proc/*/net/* too, but I would
actually expect that there are tools that cross-reference the sockets
by socket address (ie "fuser" and similar tools). So I'd like to have
that hashing for that.

Although maybe I'm wrong, and they simply use the socket number, and
the socket address could just be scrubbed entirely.


 \ /
  Last update: 2017-11-28 02:09    [W:0.103 / U:4.628 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site