[lkml]   [2017]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: d7be102f29 ("cfg80211: initialize regulatory keys/database later"): kernel BUG at crypto/asymmetric_keys/public_key.c:80!
On Mon, 2017-11-27 at 21:46 +0000, Linus Torvalds wrote:
> On Sat, Nov 25, 2017 at 7:07 PM, Fengguang Wu <> wrote:
> > FYI, we noticed the following commit (built with gcc-4.8):
> >
> > commit: d7be102f2945a626f55e0501e52bb31ba3e77b81 ("cfg80211: initialize regulatory keys/database later")
> The attached 'dmesg.xz' doesn't actually match the kernel or the
> report. Very odd.
> > [ 8.602885] kernel BUG at crypto/asymmetric_keys/public_key.c:80!
> In that reported kernel, that is
> 80 BUG_ON(!sig->digest);
> so the public key signature has no digest.

Yeah. I believe this was fixed by commit 01a95b2141e3 ("cfg80211:
select CRYPTO_SHA256 if needed"), and since that was already on the way
I didn't reply to this report specifically.

> I'm not seeing why it would ever be ok to do BUG_ON() instead of just
> returning an error, though.

That's kinda a good question - here we might fail to load this
certificate, print a key, and then never be able to load the signed
file - but at least we wouldn't crash immediately :-)


 \ /
  Last update: 2017-11-27 22:53    [W:0.058 / U:10.968 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site