lkml.org 
[lkml]   [2017]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 07/11] intel_sgx: ptrace() support
On Sun, Nov 26, 2017 at 07:50:05AM -0800, Joe Perches wrote:
> On Sun, 2017-11-26 at 17:44 +0200, Jarkko Sakkinen wrote:
> > On Sat, Nov 25, 2017 at 09:29:24PM +0200, Jarkko Sakkinen wrote:
> > > + ptr = sgx_get_page(page->epc_page);
> > > + ret = __edbgrd((unsigned long)ptr + offset, data);
> ^^^^^^
>
> > > + sgx_put_page(ptr);
> > > + if (ret) {
> > > + sgx_dbg(encl, "EDBGRD returned %d\n", ret);
> > ~~~~~~
> > EDBGWR
>
> ?

D'oh I meant to quote this part:

ptr = sgx_get_page(page->epc_page);
ret = __edbgwr((unsigned long)ptr + offset, data);
sgx_put_page(ptr);
if (ret) {
sgx_dbg(encl, "EDBGRD returned %d\n", ret);
return -EFAULT;
}

There's a typo in sgx_dbg().

/Jarkko

\
 
 \ /
  Last update: 2017-11-26 17:54    [W:0.096 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site