lkml.org 
[lkml]   [2017]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 28/43] x86/mm/kaiser: Map cpu entry area

* Thomas Gleixner <tglx@linutronix.de> wrote:

> On Fri, 24 Nov 2017, Ingo Molnar wrote:
> > +void kaiser_add_mapping_cpu_entry(int cpu)
> > +{
> > + kaiser_add_user_map_early(get_cpu_gdt_ro(cpu), PAGE_SIZE,
> > + __PAGE_KERNEL_RO);
> > +
> > + /* includes the entry stack */
> > + kaiser_add_user_map_early(&get_cpu_entry_area(cpu)->tss,
> > + sizeof(get_cpu_entry_area(cpu)->tss),
> > + __PAGE_KERNEL | _PAGE_GLOBAL);
> > +
> > + /* Entry code, so needs to be EXEC */
> > + kaiser_add_user_map_early(&get_cpu_entry_area(cpu)->entry_trampoline,
> > + sizeof(get_cpu_entry_area(cpu)->entry_trampoline),
> > + __PAGE_KERNEL_EXEC | _PAGE_GLOBAL);
>
> This creates a RWX mapping and wants to be __PAGE_KERNEL_RX!

So I think __PAGE_KERNEL_EXEC and __PAGE_KERNEL are really dangerous names which
creates RWX mappings without people intending it.

Should be renamed to something like __PAGE_KERNEL_RWX ? And not be used anywhere ...

Thanks,

Ingo

\
 
 \ /
  Last update: 2017-11-26 16:20    [W:0.072 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site