lkml.org 
[lkml]   [2017]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] drm/rockchip: dma-mapping: Use vma_pages helper
Date
Thanks, this update has merged to drm-misc-next months ago:

https://patchwork.freedesktop.org/patch/178255/


在 2017/11/22 23:24, Vasyl Gomonovych 写道:
> Use vma_pages function on vma object instead of explicit computation.
> ./drivers/gpu/drm/rockchip/rockchip_drm_gem.c:223:34-40: WARNING: Consider using vma_pages helper on vma
> Generated by: scripts/coccinelle/api/vma_pages.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index 1869c8bb76c8..1d9655576b6e 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_iommu(struct drm_gem_object *obj,
>   {
>       struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
>       unsigned int i, count = obj->size >> PAGE_SHIFT;
> -    unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> +    unsigned long user_count = vma_pages(vma);
>       unsigned long uaddr = vma->vm_start;
>       unsigned long offset = vma->vm_pgoff;
>       unsigned long end = user_count + offset;
>


\
 
 \ /
  Last update: 2017-11-27 03:21    [W:0.029 / U:1.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site