lkml.org 
[lkml]   [2017]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm64: dts: Hi3660: Fix state id for 'CPU_NAP' state
Hi Sudeep,

On Fri, Nov 24, 2017 at 02:39:47PM +0000, Sudeep Holla wrote:

[...]

> > Come back to recommended state id, I reviewed Juno board defintion and
> > I found it's not align with PSCI spec defintion, in ARM-TF Juno code
> > defines state as below [1]:
> >
>
> Yes Juno is almost 4 years old now, so it may not be too good a
> reference platform for latest and greatest platforms like hikey2 ;)
> As I said, Juno predates the recommendation in the PSCI spec.
>
> > #define ARM_LOCAL_STATE_RUN 0
> > #define ARM_LOCAL_STATE_RET 1
> > #define ARM_LOCAL_STATE_OFF 2
> >
> > In PSCI spec chapter "6.5 Recommended StateID Encoding" recommends power
> > state id as below:
> >
> > 0: Run
> > 1: Standby
> > 2: Retention
> > 3: Powerdown
> >
> > So could you confirm on Hikey960 we should follow PSCI definition for
> > state id definition?
> >
>
> Yes, I don't see any reason not to, as this may become reference to some
> other platform, it's good to keep it aligned so that copy paste happens
> in a good sense for future platforms. :)

Thanks for upper confirmation.

> >> Juno's implementation is legacy as these recommendations were added
> >> later in the specification while Juno is 3 year old platform now.
> >>
> >> Though strictly speaking it's not violation of the PSCI specification,
> >> but I would rather get this fixed not before it's too late and copied to
> >> the next generation of platforms. Since the firmware can be easily
> >> upgraded that shouldn't be that difficult.
> >
> > If completely compliant with PSCI recommended state id, we need change
> > both for ARM-TF and kernel for this. In ARM-TF, I have sent PR [2].
> >
>
> OK
>
> > For the kernel patch, we should change state id as below. Please let me
> > know if you have suggestion for this.
> >
>
> I would wait until ATF changes are merged before you patch DT in the kernel.

Agree, will sent new version patch after ATF patch merging ahead.

Thank you for suggestions.
Leo Yan

\
 
 \ /
  Last update: 2017-11-27 03:02    [W:0.033 / U:3.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site