lkml.org 
[lkml]   [2017]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line
From
Date
On Sun, 2017-11-26 at 10:38 -0700, Logan Gunthorpe wrote:
>
> On 25/11/17 11:01 PM, Joe Perches wrote:
> > It doesn't really work.
>
> That's rather hyperbolic and I don't appreciate the tone.

What I wrote is neither hyperbolic nor tonal.

I'm rather familiar with checkpatch.

High false positive messages are avoided by checkpatch and
new tests with high false positive rates are not accepted.

This proposal has a very high false positive rate.

So, as written. nack.

Keep at it though.
Maybe something useful will be produced with more effort.

cheers, Joe

\
 
 \ /
  Last update: 2017-11-26 23:29    [W:0.058 / U:26.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site