lkml.org 
[lkml]   [2017]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] nvmem: core: Deduplicate bus_find_device() by name matching
From
Date
Thanks for the patch,

On 25/11/17 11:31, Lukas Wunner wrote:
> No need to reinvent the wheel, we have bus_find_device_by_name().
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> ---
> drivers/nvmem/core.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
It looks good for me, I will queue it up!

> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 5a5cefd12153..93084ab61e0f 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -600,16 +600,11 @@ static void __nvmem_device_put(struct nvmem_device *nvmem)
> mutex_unlock(&nvmem_mutex);
> }
>
> -static int nvmem_match(struct device *dev, void *data)
> -{
> - return !strcmp(dev_name(dev), data);
> -}
> -
> static struct nvmem_device *nvmem_find(const char *name)
> {
> struct device *d;
>
> - d = bus_find_device(&nvmem_bus_type, NULL, (void *)name, nvmem_match);
> + d = bus_find_device_by_name(&nvmem_bus_type, NULL, name);
>
> if (!d)
> return NULL;
>

\
 
 \ /
  Last update: 2017-11-25 15:48    [W:0.032 / U:2.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site