Messages in this thread | | | Subject | Re: [PATCH] pata_pdc2027x: Fix coding sytle error | From | arvindY <> | Date | Sat, 25 Nov 2017 16:40:14 +0530 |
| |
Hi Joe,
On Saturday 25 November 2017 04:32 PM, Joe Perches wrote: > On Sat, 2017-11-25 at 16:04 +0530, Arvind Yadav wrote: > [] >> diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c > [] >> @@ -84,7 +84,7 @@ static int pdc2027x_set_mode(struct ata_link *link, struct ata_device **r_failed >> */ >> static struct pdc2027x_pio_timing { >> u8 value0, value1, value2; >> -} pdc2027x_pio_timing_tbl [] = { >> +} pdc2027x_pio_timing_tbl[] = { >> { 0xfb, 0x2b, 0xac }, /* PIO mode 0 */ >> { 0x46, 0x29, 0xa4 }, /* PIO mode 1 */ >> { 0x23, 0x26, 0x64 }, /* PIO mode 2 */ > trivia: > > It seems all the <foo>_timing_tbl structs should be const > Yes, It should be const. I will push anther patch.
~arvind
| |