Messages in this thread | | | Subject | Re: [PATCH] pata_pdc2027x: Remove unnecessary error check and coding style error. | From | arvindY <> | Date | Sat, 25 Nov 2017 15:49:33 +0530 |
| |
Hi Sergei,
On Saturday 25 November 2017 03:30 PM, Sergei Shtylyov wrote: > On 11/25/2017 7:15 AM, Arvind Yadav wrote: > >> Here, The function pdc_hardware_init always return zero. So it is not >> necessary to check its return value. >> >> Fix these checkpatch.pl error: >> >> ERROR: space prohibited after that '~' (ctx:WxW) >> + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); >> >> ERROR: spaces required around that '?' (ctx:VxW) >> + long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ; >> >> ERROR: that open brace { should be on the previous line >> + const struct ata_port_info *ppi[] = >> + { &pdc2027x_port_info[board_idx], NULL }; >> > > Please fix the checkpatch.pl errors in a sperate patch. Please find a patch v3, which does not include checkpatch.pl error fix. > >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > [...] > > MBR, Sergei ~arvind
| |