lkml.org 
[lkml]   [2017]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] input: pegasus_notetaker: add license information
Hi Martin,

On Sat, Nov 18, 2017 at 09:45:18AM +0100, Martin Kepplinger wrote:
> This adds an SPDX license identifier to this driver I wrote some time back.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> drivers/input/tablet/pegasus_notetaker.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/tablet/pegasus_notetaker.c b/drivers/input/tablet/pegasus_notetaker.c
> index 47de5a81172f..cdf75c989469 100644
> --- a/drivers/input/tablet/pegasus_notetaker.c
> +++ b/drivers/input/tablet/pegasus_notetaker.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0

Should this be GPL-2.0+? The MODULE_LICENSE specifies that the module is
"GPL" which in kernel land means GPLv2+. Or we should change the module
license to strict "GPLv2"?

Also, why do we use C++ -style comments for this?

Greg, do you have any plans on dropping MODULE_LICENSE() altogether and
generating the appropriate string from SPDX markings in the source?
Doing this would prevent mismatches between license notices, SPDX tags
and MODULE_LCENSE() strings, which happen very often.

> /*
> * Pegasus Mobile Notetaker Pen input tablet driver
> *

Thanks.

--
Dmitry

\
 
 \ /
  Last update: 2017-11-26 01:43    [W:0.101 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site