lkml.org 
[lkml]   [2017]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Re: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.
On Fri 24-11-17 13:30:25, Vaneet Narang wrote:
> Hi Michal,
>
> >> We have been getting similar kind of such entries and eventually
> >> stackdepot reaches Max Cap. So we found this interface useful in debugging
> >> stackdepot issue so shared in community.
>  
> >Then use it for internal debugging and provide a code which would scale
> >better on smaller systems. We do not need this in the kernel IMHO. We do
> >not merge all the debugging patches we use for internal development.
> ` 
> Not just debugging but this information can also be used to profile and tune stack depot.
> Getting count of stack entries would help in deciding hash table size and
> page order used by stackdepot.

How can you control that in runtime?

> For less entries, bigger hash table and higher page order slabs might not be required as
> maintained by stackdepot. As i already mentioned smaller size hashtable can be choosen and
> similarly lower order pages can be used for slabs.
>
> If you think its useful, we can share scalable patch to configure below two values based on
> number of stack entries dynamically.

Exporting this data without having a way to control it is just not very
useful for upstream kernel. If you can come up with some dynamic tuning
then that might be interesting. But your patch doesn't seem useful
outside of the development enviroment AFAICS.

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2017-11-24 14:48    [W:0.037 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site