lkml.org 
[lkml]   [2017]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions
On Fri, Nov 24, 2017 at 9:21 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:

> diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> index 4bdf29169d2a..f8b267875e1c 100644
> --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
> @@ -276,6 +276,23 @@
> compatible = "sst,sst25vf016b", "jedec,spi-nor";
> spi-max-frequency = <20000000>;
> reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition@0 {
> + label = "U-Boot";

What about calling it something more generic, like "bootloader"?

U-Boot is not the only bootloader that can run on this board.

You could also consider passing the 'read-only' property like it is
done in imx6sx-nitrogen6sx.dts.

> + reg = <0x0 0xc0000>;
> + };
> +
> + partition@c0000 {
> + label = "U-Boot Environment";

Maybe just 'env' and add 'read-only' property here as well.

\
 
 \ /
  Last update: 2017-11-24 14:45    [W:0.031 / U:20.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site