lkml.org 
[lkml]   [2017]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: Re: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.
From
Date
Hi Michal,

>> We have been getting similar kind of such entries and eventually
>> stackdepot reaches Max Cap. So we found this interface useful in debugging
>> stackdepot issue so shared in community.
 
>Then use it for internal debugging and provide a code which would scale
>better on smaller systems. We do not need this in the kernel IMHO. We do
>not merge all the debugging patches we use for internal development.

Not just debugging but this information can also be used to profile and tune stack depot.
Getting count of stack entries would help in deciding hash table size and
page order used by stackdepot.

For less entries, bigger hash table and higher page order slabs might not be required as
maintained by stackdepot. As i already mentioned smaller size hashtable can be choosen and
similarly lower order pages can be used for slabs.

If you think its useful, we can share scalable patch to configure below two values based on
number of stack entries dynamically.

#define STACK_ALLOC_ORDER 2
#define STACK_HASH_SIZE (1L << STACK_HASH_ORDER)


Regards,
Vaneet Narang

\
 
 \ /
  Last update: 2017-11-24 14:42    [W:0.060 / U:1.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site