Messages in this thread Patch in this message |  | | From | Adam Thomson <> | Subject | RE: [PATCH 2/2] ASoC: da7213: Improve a size determination in da7213_i2c_probe() | Date | Fri, 24 Nov 2017 11:49:08 +0000 |
| |
On 23 November 2017 17:34, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net> > Date: Thu, 23 Nov 2017 18:15:30 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> --- > sound/soc/codecs/da7213.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c > index d1b77a0e3b74..b2b4e90fc02a 100644 > --- a/sound/soc/codecs/da7213.c > +++ b/sound/soc/codecs/da7213.c > @@ -1853,8 +1853,7 @@ static int da7213_i2c_probe(struct i2c_client *i2c, > struct da7213_priv *da7213; > int ret; > > - da7213 = devm_kzalloc(&i2c->dev, sizeof(struct da7213_priv), > - GFP_KERNEL); > + da7213 = devm_kzalloc(&i2c->dev, sizeof(*da7213), GFP_KERNEL); > if (!da7213) > return -ENOMEM; > > -- > 2.15.0
|  |