lkml.org 
[lkml]   [2017]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] frv: fix build failure
    Date
    Hi Sudip,

    On Thu, 2017-11-23 at 23:01 +0000, Sudip Mukherjee wrote:
    > Hi Alexey,
    >
    > On Thu, Nov 23, 2017 at 05:17:19PM +0000, Alexey Brodkin wrote:
    > >
    > > Hi Sudip,
    > >
    > > On Tue, 2017-11-21 at 22:10 +0000, Sudip Mukherjee wrote:
    > > >
    > > > The frv defconfig build is failing with the error:
    > > > lib/mpi/mpih-div.o: In function `mpihelp_divrem':
    > > > mpih-div.c:(.text+0x30c): undefined reference to `abort'
    > > >
    > > > The function 'abort' was never defined for the frv architecture.
    > > > Create 'abort' as is done in other arch like 'arm' and 'unicore32'.
    > > >
    > > > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
    > > > ---
    > >
    > > I'm seeing the same issue building for ARC from today's Linus' tree.
    > > Maybe it worth implementing abort() as a weak function for every arch/platform
    > > that doesn't have it explicitly defined? Otherwise we'll end-up with
    > > useless code duplication.
    >
    > Do you mean define it for every arch or define it in a common place so
    > that all arch can use it?

    Essentially I'd prefer to have just 1 instance of this function.
    In fact I'd even remove existing implementations in ARM, Unicore32 and M32R
    and have a generic implementation as this function obviously has nothing arch-specific.

    > I did a quick try with the attached patch on two different arch, one of
    > them (m32r) has the 'abort' defined and the other (frv) was failing due
    > to lack of abort, and they both built without any warnings or errors.

    Well maybe add  call to panic() there as well as it is done for ARM, unicore32 and M32R?

    > But I am not sure if 'kernel/exit.c' is the right place for it.
    > Any suggestion?

    I guess it should be indeed something in "kernel/" and maybe your existing choice
    of "kernel/exit.c" is not bad. Just send a patch to LKML and you'll get much better
    guidance on that I guess :)

    Anyways thanks for looking at this one.

    -Alexey
    \
     
     \ /
      Last update: 2017-11-24 06:05    [W:3.157 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site