lkml.org 
[lkml]   [2017]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] mm,vmscan: Kill global shrinker lock.
On Thu, Nov 16, 2017 at 12:44:22PM -0500, Johannes Weiner wrote:
> On Wed, Nov 15, 2017 at 09:56:02AM +0900, Minchan Kim wrote:
> > @@ -498,6 +498,14 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
> > sc.nid = 0;
> >
> > freed += do_shrink_slab(&sc, shrinker, nr_scanned, nr_eligible);
> > + /*
> > + * bail out if someone want to register a new shrinker to prevent
> > + * long time stall by parallel ongoing shrinking.
> > + */
> > + if (rwsem_is_contended(&shrinker_rwsem)) {
> > + freed = 1;
> > + break;
> > + }
> > }
>
> When you send the formal version, please include
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Thanks for the review, Johannes.

\
 
 \ /
  Last update: 2017-11-24 00:47    [W:0.074 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site