lkml.org 
[lkml]   [2017]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 2/4] platform/x86: intel_telemetry: Fix suspend stats
On Tue, Nov 21, 2017 at 4:36 PM, Souvik Kumar Chakravarty
<souvik.k.chakravarty@intel.com> wrote:
> Suspend stats are not reported consistently due to a limitation in the PMC
> firmware. This limitation causes a delay in updating the s0ix counters and
> residencies in the telemetry log upon s0ix exit. As a consequence, reading
> these counters from the suspend-exit notifier may result in zero read.
>
> This patch fixes this issue by cross-verifying the s0ix residencies from
> the GCR TELEM registers in case the counters are not incremented in the
> telemetry log after suspend.
>
> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=197833
>
> We also remove unnecessary 'static' qualifiers from local variables.
>
> Reported-and-tested-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
> Signed-off-by: Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com>

> - static u32 suspend_shlw_ctr_exit, suspend_deep_ctr_exit;
> - static u64 suspend_shlw_res_exit, suspend_deep_res_exit;
> struct telemetry_debugfs_conf *conf = debugfs_conf;
> + u32 suspend_shlw_ctr_exit, suspend_deep_ctr_exit;
> + u64 suspend_shlw_res_exit, suspend_deep_res_exit;
> int ret, index;

> + if (suspend_shlw_ctr_exit == suspend_shlw_ctr_temp &&
> + suspend_deep_ctr_exit == suspend_deep_ctr_temp) {

kbuildbot is absolutely right. How this code is supposed to work? It's flaky.

Please, redesign this approach.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-11-23 22:25    [W:0.095 / U:0.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site