lkml.org 
[lkml]   [2017]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] perf intel-pt: Improve build messages for files that differ from the kernel
Em Tue, Nov 21, 2017 at 09:41:11AM +0100, Ingo Molnar escreveu:
> * Adrian Hunter <adrian.hunter@intel.com> wrote:
> > + ((diff -B -I'^#include' util/intel-pt-decoder/inat_types.h ../../arch/x86/include/asm/inat_types.h >/dev/null) || \
> > + (echo "Warning: Intel PT: x86 instruction decoder header at 'tools/perf/util/intel-pt-decoder/inat_types.h' differs from latest version at 'arch/x86/include/asm/inat_types.h'" >&2)))) || true
> > $(call rule_mkdir)
> > $(call if_changed_dep,cc_o_c)
>
> Could we please factor this out into a helper, sharing more code with
> tools/perf/check-headers.sh?

I'll do that at some point, applying the patch as the message got
improved.

> Also, I'd suggest removing this from check-headers.sh:
>
> opts="--ignore-blank-lines --ignore-space-change"

Done already.

- Arnaldo

\
 
 \ /
  Last update: 2017-11-23 19:42    [W:0.049 / U:6.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site