lkml.org 
[lkml]   [2017]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] MIPS: ralink: Fix platform_get_irq's error checking
From
Date
On 11/23/2017 06:45 PM, Arvind Yadav wrote:

> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2: Subject spelling was not correct. change FIX in place
> of 'ix'.
>
> arch/mips/ralink/timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c
> index d4469b2..913dc84b 100644
> --- a/arch/mips/ralink/timer.c
> +++ b/arch/mips/ralink/timer.c
> @@ -109,7 +109,7 @@ static int rt_timer_probe(struct platform_device *pdev)
> }
>
> rt->irq = platform_get_irq(pdev, 0);
> - if (!rt->irq) {
> + if (rt->irq < 0) {
> dev_err(&pdev->dev, "failed to load irq\n");
> return -ENOENT;

Also makes sense to propagate the error instead of -ENOENT...

[...]

MBR, Sergei

\
 
 \ /
  Last update: 2017-11-23 19:39    [W:0.042 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site