lkml.org 
[lkml]   [2017]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 4/4] test: add a test for the process_vmsplice syscall
On Thu, Nov 23, 2017 at 09:01:03AM +0100, Greg KH wrote:
> On Wed, Nov 22, 2017 at 09:36:31PM +0200, Mike Rapoport wrote:
> > From: Andrei Vagin <avagin@openvz.org>
> >
> > This test checks that process_vmsplice() can splice pages from a remote
> > process and returns EFAULT, if process_vmsplice() tries to splice pages
> > by an unaccessiable address.
> >
> > Signed-off-by: Andrei Vagin <avagin@openvz.org>
> > ---
> > tools/testing/selftests/process_vmsplice/Makefile | 5 +
> > .../process_vmsplice/process_vmsplice_test.c | 188 +++++++++++++++++++++
> > 2 files changed, 193 insertions(+)
> > create mode 100644 tools/testing/selftests/process_vmsplice/Makefile
> > create mode 100644 tools/testing/selftests/process_vmsplice/process_vmsplice_test.c
> >

[ ... ]

>
> Shouldn't you check to see if the syscall is even present? You should
> not error if it is not, as this test will then "fail" on kernels/arches
> without the syscall enabled, which isn't the nicest.

Sure, will fix.

> thanks,
>
> greg k-h
>

--
Sincerely yours,
Mike.

\
 
 \ /
  Last update: 2017-11-23 15:08    [W:0.073 / U:35.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site