lkml.org 
[lkml]   [2017]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Qemu-devel] qemu x86 CPUID leafs override
From
Date
Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] qemu x86 CPUID leafs override
Type: series
Message-id: 20171123131331.5jyqwlbgthijqgl7@pd.tnic

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/1511388334-16347-1-git-send-email-pmorel@linux.vnet.ibm.com -> patchew/1511388334-16347-1-git-send-email-pmorel@linux.vnet.ibm.com
* [new tag] patchew/20171123131331.5jyqwlbgthijqgl7@pd.tnic -> patchew/20171123131331.5jyqwlbgthijqgl7@pd.tnic
Switched to a new branch 'test'
e148d5c86c qemu x86 CPUID leafs override

=== OUTPUT BEGIN ===
Checking PATCH 1/1: qemu x86 CPUID leafs override...
ERROR: code indent should never use tabs
#39: FILE: target/i386/cpu.c:2740:
+^I env->cpuid_xlevel = cpu->cpuid_leaf;$

ERROR: code indent should never use tabs
#52: FILE: target/i386/cpu.c:3154:
+^I if (cpu->eax)$

ERROR: braces {} are necessary for all arms of this statement
#52: FILE: target/i386/cpu.c:3154:
+ if (cpu->eax)
[...]

ERROR: code indent should never use tabs
#53: FILE: target/i386/cpu.c:3155:
+^I^I *eax = cpu->eax;$

ERROR: code indent should never use tabs
#55: FILE: target/i386/cpu.c:3157:
+^I if (cpu->ebx)$

ERROR: braces {} are necessary for all arms of this statement
#55: FILE: target/i386/cpu.c:3157:
+ if (cpu->ebx)
[...]

ERROR: code indent should never use tabs
#56: FILE: target/i386/cpu.c:3158:
+^I^I *ebx = cpu->ebx;$

ERROR: code indent should never use tabs
#58: FILE: target/i386/cpu.c:3160:
+^I if (cpu->ecx)$

ERROR: braces {} are necessary for all arms of this statement
#58: FILE: target/i386/cpu.c:3160:
+ if (cpu->ecx)
[...]

ERROR: code indent should never use tabs
#59: FILE: target/i386/cpu.c:3161:
+^I^I *ecx = cpu->ecx;$

ERROR: code indent should never use tabs
#61: FILE: target/i386/cpu.c:3163:
+^I if (cpu->edx)$

ERROR: braces {} are necessary for all arms of this statement
#61: FILE: target/i386/cpu.c:3163:
+ if (cpu->edx)
[...]

ERROR: code indent should never use tabs
#62: FILE: target/i386/cpu.c:3164:
+^I^I *edx = cpu->edx;$

ERROR: Missing Signed-off-by: line(s)

total: 14 errors, 0 warnings, 59 lines checked

Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
\
 
 \ /
  Last update: 2017-11-23 14:19    [W:0.032 / U:2.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site