lkml.org 
[lkml]   [2017]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 8/9] perf stat: Remove --per-thread pid/tid limitation
On Wed, Nov 22, 2017 at 11:42:05AM +0800, Jin, Yao wrote:
>
>
> On 11/21/2017 11:18 PM, Jiri Olsa wrote:
> > On Mon, Nov 20, 2017 at 10:43:43PM +0800, Jin Yao wrote:
> >
> > SNIP
> >
> > > - if ((stat_config.aggr_mode == AGGR_THREAD) && !target__has_task(&target)) {
> > > - fprintf(stderr, "The --per-thread option is only available "
> > > - "when monitoring via -p -t options.\n");
> > > - parse_options_usage(NULL, stat_options, "p", 1);
> > > - parse_options_usage(NULL, stat_options, "t", 1);
> > > - goto out;
> > > + if ((stat_config.aggr_mode == AGGR_THREAD) &&
> > > + !target__has_task(&target)) {
> > > + if (!target.system_wide || target.cpu_list) {
> > > + fprintf(stderr, "The --per-thread option is only "
> > > + "available when monitoring via -p -t "
> > > + "options.\n");
> >
> > the message should be updated with '-a' option, that you just added,
>
> OK. Could I update the message like this?
>
> "The --per-thread option is only "
> "available when monitoring via -p -t -a"
> "options or only --per-thread without any other option"
>
> > also why dont we support target.cpu_list, it should work no?
> >
>
> Currently it doesn't support cpu_list.
>
> I just think this patch series is too big and I wish to add supporting for
> cpu_list, cgroup or others in follow up patches.
>
> Is that OK?

ok, thanks

jirka

\
 
 \ /
  Last update: 2017-11-22 09:35    [W:0.094 / U:0.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site