lkml.org 
[lkml]   [2017]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/62] radix tree: Add a missing cast to gfp_t
On Wed, Nov 22, 2017 at 02:24:02PM -0800, Matthew Wilcox wrote:
> On Wed, Nov 22, 2017 at 10:28:48PM +0100, Luc Van Oostenryck wrote:
> > > - root->gfp_mask &= (1 << ROOT_TAG_SHIFT) - 1;
> > > + root->gfp_mask &= (__force gfp_t)((1 << ROOT_TAG_SHIFT) - 1);
> >
> > IMO, it would be better to define something for that in radix-tree.h,
> > like it has been done for ROOT_IS_IDR.
>
> If we were keeping the radix tree around, I'd agree, but the point of
> the rest of this patch set is replacing it ;-) I should probably have
> just dropped this patch, to be honest.

Ah OK, sure.
I confess I didn't saw the whole series, just this patch.

-- Luc

\
 
 \ /
  Last update: 2017-11-22 23:36    [W:0.049 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site