lkml.org 
[lkml]   [2017]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 07/18] x86/asm: Fix assumptions that the HW TSS is at the beginning of cpu_tss
On Tue, Nov 21, 2017 at 08:44:02PM -0800, Andy Lutomirski wrote:
> I'm going to move SYSENTER_stack to the beginning of cpu_tss to help
> detect overflow. Before this can happen, I need to fix several code
> paths that hardcode assumptions about the old layout.

Please formulate that commit message in passive-impersonal: "Fix
hardcoded assumptions about ... before ..."

>
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> arch/x86/include/asm/desc.h | 2 +-
> arch/x86/include/asm/processor.h | 4 ++--
> arch/x86/kernel/cpu/common.c | 8 ++++----
> arch/x86/kernel/doublefault.c | 36 +++++++++++++++++-------------------
> arch/x86/power/cpu.c | 13 +++++++------
> 5 files changed, 31 insertions(+), 32 deletions(-)

With that:

Reviewed-by: Borislav Petkov <bp@suse.de>

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

\
 
 \ /
  Last update: 2017-11-22 20:07    [W:0.296 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site