lkml.org 
[lkml]   [2017]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license
On Wed, Nov 22, 2017 at 06:07:13PM +0100, Pavel Machek wrote:
> Lets look at random file in usb:
>
> // SPDX-License-Identifier: GPL-2.0+
> /*
> * Driver for SMSC USB3503 USB 2.0 hub controller driver
> *
> * Copyright (c) 2012-2013 Dongjin Kim (tobetter@gmail.com)
> */
> ...
> MODULE_LICENSE("GPL");
>
> ...do we agree that this is nowhere near distration-free? Ugly //
> comment that screams for attention, away from other copyright info, it
> hurts your eyes...
>
> This would be improvement:
>
> /*
> * Driver for SMSC USB3503 USB 2.0 hub controller driver
> *
> * Copyright (c) 2012-2013 Dongjin Kim (tobetter@gmail.com)
> *
> * SPDX-License-Identifier: GPL-2.0+
> */
>
> ...but what is above is just uuuugly.
>
> ...as is MODULE_LICENSE having completely different tags from SPDX.
>
> This would be even better:
>
> /*
> * Driver for SMSC USB3503 USB 2.0 hub controller driver
> *
> * Copyright (c) 2012-2013 Dongjin Kim (tobetter@gmail.com)
> */
> ...
> SPDX_MODULE_LICENSE("GPL-2.0+")
>
> So yes, SPDX can be improvement. But in current implementation it is
> not.

Again, as people seem to keep still missing this point, Linus asked for
the format to look like it does today, using // at the top. Thomas and
I originally did it first the way with the SPDX line in the big comment
block.

If you don't like the format, complain and convince him otherwise, you
are not getting anywhere by responding to this old topic about it
again.

Having it be the first line of the file is good, it's obvious, and
stands out, which is the point, you want it to, it's a license :)

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-11-22 18:54    [W:0.137 / U:7.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site