[lkml]   [2017]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 05/18] x86/fixmap: Generalize the GDT fixmap mechanism
On Wed, Nov 22, 2017 at 09:16:00AM -0800, Andy Lutomirski wrote:
> Agreed, except that the fixmap enum needs to know
> sizeof(cpu_entry_area), and I'm really hesitant to add yet another
> header dependency.

Perhaps a separate asm/cpuarea.h. asm/cpu.h looks small enough but it
has hotplug and other misc stuff in there.

Bah, our header separation needs a serious cleanup. ;-\

> My general habit is that I like the != 0 here because I'm doing
> arithmetic rather than thinking of % as some kind of logical operator.
> I.e. I find it easier to understand the way I wrote it.

I know, and I can recognize the code you wrote in arch/x86/ just by
those tests, without looking at git blame output. :-)

In my case, without the != 0 reads easier.


SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

 \ /
  Last update: 2017-11-22 18:33    [W:0.098 / U:4.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site