Messages in this thread | | | Subject | Re: [PATCH 29/30] i7300_idle: deprecate pci_get_bus_and_slot() | From | Sinan Kaya <> | Date | Wed, 22 Nov 2017 11:15:47 -0500 |
| |
On 11/22/2017 2:53 AM, Greg Kroah-Hartman wrote: >> +++ b/include/linux/i7300_idle.h >> @@ -48,7 +48,7 @@ static inline int i7300_idle_platform_probe(struct pci_dev **fbd_dev, >> int i; >> struct pci_dev *memdev, *dmadev; >> >> - memdev = pci_get_bus_and_slot(MEMCTL_BUS, MEMCTL_DEVFN); >> + memdev = pci_get_domain_bus_and_slot(0, MEMCTL_BUS, MEMCTL_DEVFN); > You have a pci_dev, why can't you use it here to get the domain? >
Both fbd_dev and ioat_dev are output parameters.
dmadev = pci_get_bus_and_slot(IOAT_BUS, IOAT_DEVFN); memdev = pci_get_bus_and_slot(MEMCTL_BUS, MEMCTL_DEVFN);
for (i = 0; fbd_ioat_list[i].vendor != 0; i++) { if (dmadev->vendor == fbd_ioat_list[i].vendor && dmadev->device == fbd_ioat_list[i].ioat_dev) { if (!(fbd_ioat_list[i].enabled || enable_all)) continue;
if (fbd_dev) *fbd_dev = memdev; if (ioat_dev) *ioat_dev = dmadev;
Funny thing is nobody is calling this function. Maybe, I should just kill it instead.
-- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |