lkml.org 
[lkml]   [2017]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Staging: sm750fb: sm750: fixed coding style issues
From
Date
On Wed, 2017-11-22 at 16:42 +0100, Patryk Kocielnik wrote:
> Cleaned checkpatch warnings by fixing coding style issues.

checkpatch is not always correct.

> Signed-off-by: Patryk Kocielnik <patryk.kocielnik@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
[]
> @@ -32,7 +32,7 @@
> static int g_hwcursor = 1;
> static int g_noaccel;
> static int g_nomtrr;
> -static const char *g_fbmode[] = {NULL, NULL};
> +static const char * const g_fbmode[] = {NULL, NULL};

Make sure you compile any file modified by a patch
_before_ submitting the proposed patch.

> static const char *g_def_fbmode = "1024x768-32@60";
> static char *g_settings;
> static int g_dualview;
> @@ -749,7 +749,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
> lynx750_ext, NULL, vesa_modes,
> };
> int cdb[] = {ARRAY_SIZE(lynx750_ext), 0, VESA_MODEDB_SIZE};
> - static const char *mdb_desc[] = {
> + static const char * const mdb_desc[] = {
> "driver prepared modes",
> "kernel prepared default modedb",
> "kernel HELPERS prepared vesa_modes",

\
 
 \ /
  Last update: 2017-11-22 17:03    [W:0.048 / U:11.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site