Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH] USB: gadget: legacy: remove redundant zero assignment to variable 'value' | Date | Wed, 22 Nov 2017 14:40:48 +0000 |
| |
From: Colin Ian King <colin.king@canonical.com>
The variable value is being assigned to zero but that value is never being read. Either value is being reassigned in the following if condition, or it is never read and the function returns. In both cases the assignment is redundant and can be removed. Cleans up clang warning:
drivers/usb/gadget/legacy/inode.c:1473:4: warning: Value stored to 'value' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/usb/gadget/legacy/inode.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c index 9343ec436485..cb8e1761d405 100644 --- a/drivers/usb/gadget/legacy/inode.c +++ b/drivers/usb/gadget/legacy/inode.c @@ -1470,7 +1470,6 @@ gadgetfs_setup (struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl) dev->setup_wLength = w_length; dev->setup_out_ready = 0; dev->setup_out_error = 0; - value = 0; /* read DATA stage for OUT right away */ if (unlikely (!dev->setup_in && w_length)) { -- 2.14.1
| |