Messages in this thread | | | Subject | Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format | From | Joe Perches <> | Date | Wed, 22 Nov 2017 18:38:36 -0800 |
| |
On Thu, 2017-11-23 at 11:35 +0900, Chanwoo Choi wrote: > On 2017년 11월 23일 11:29, Joe Perches wrote: > > On Thu, 2017-11-23 at 11:23 +0900, Chanwoo Choi wrote: > > > On 2017년 11월 23일 11:18, Joe Perches wrote: > > > > never break user-visible strings such as > > > > printk messages, because that breaks the ability to grep for them > > > > > > So, I suggested "Or, we better to modify the error message within 80 char.". > > > > Run checkpatch on your suggestion. > > You will get a "split_string" warning. > > I knew about this. I don't like to hurt the readability > in order to fix the warning with the improper way. > > If you want to fix it, I suggested that you better to modify > the error message within 80 char. Or I prefer the Myungjoo's opinion.
Again, I don't really care how it's fixed, but the 3 tabs in the middle of the message are stupid.
Please fix it.
| |