lkml.org 
[lkml]   [2017]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] rk3399_dmc: Fix line continuation format
On 2017년 11월 23일 11:29, Joe Perches wrote:
> On Thu, 2017-11-23 at 11:23 +0900, Chanwoo Choi wrote:
>> On 2017년 11월 23일 11:18, Joe Perches wrote:
>>> never break user-visible strings such as
>>> printk messages, because that breaks the ability to grep for them
>>
>> So, I suggested "Or, we better to modify the error message within 80 char.".
>
> Run checkpatch on your suggestion.
> You will get a "split_string" warning.

I knew about this. I don't like to hurt the readability
in order to fix the warning with the improper way.

If you want to fix it, I suggested that you better to modify
the error message within 80 char. Or I prefer the Myungjoo's opinion.

--
Best Regards,
Chanwoo Choi
Samsung Electronics

\
 
 \ /
  Last update: 2017-11-23 03:36    [W:0.107 / U:1.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site