lkml.org 
[lkml]   [2017]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] drm/sti: Handle return value of platform_get_irq_byname
2017-11-17 11:36 GMT+01:00 Arvind Yadav <arvind.yadav.cs@gmail.com>:
> platform_get_irq_byname() can fail here and we must check its return
> value.
>

Applied on drm-misc-next.

Thanks,
Benjamin

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/gpu/drm/sti/sti_hdmi.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> index 30f02d2..adabd41 100644
> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> @@ -1414,6 +1414,11 @@ static int sti_hdmi_probe(struct platform_device *pdev)
> init_waitqueue_head(&hdmi->wait_event);
>
> hdmi->irq = platform_get_irq_byname(pdev, "irq");
> + if (hdmi->irq < 0) {
> + DRM_ERROR("Cannot get HDMI irq\n");
> + ret = hdmi->irq;
> + goto release_adapter;
> + }
>
> ret = devm_request_threaded_irq(dev, hdmi->irq, hdmi_irq,
> hdmi_irq_thread, IRQF_ONESHOT, dev_name(dev), hdmi);
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2017-11-21 10:14    [W:0.036 / U:19.568 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site