lkml.org 
[lkml]   [2017]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 33/61] driver core: bus: Fix a potential double free
    3.2.96-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    commit 0f9b011d3321ca1079c7a46c18cb1956fbdb7bcb upstream.

    The .release function of driver_ktype is 'driver_release()'.
    This function frees the container_of this kobject.

    So, this memory must not be freed explicitly in the error handling path of
    'bus_add_driver()'. Otherwise a double free will occur.

    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/base/bus.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/base/bus.c
    +++ b/drivers/base/bus.c
    @@ -684,7 +684,7 @@ int bus_add_driver(struct device_driver

    out_unregister:
    kobject_put(&priv->kobj);
    - kfree(drv->p);
    + /* drv->p is freed in driver_release() */
    drv->p = NULL;
    out_put_bus:
    bus_put(bus);
    \
     
     \ /
      Last update: 2017-11-22 04:01    [W:4.129 / U:0.712 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site